Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable london hardfork if burn contract address is not provided #1454

Merged
merged 2 commits into from
May 1, 2023
Merged

Disable london hardfork if burn contract address is not provided #1454

merged 2 commits into from
May 1, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Apr 28, 2023 •
edited
Loading

Description

Disable london hardfork if burn contract address is not provided when generating genesis file using CLI.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Apr 28, 2023
Stefan-Ethernal
Stefan-Ethernal approved these changes Apr 29, 2023
View reviewed changes
command/genesis/polybft_params.go Outdated Show resolved Hide resolved
command/genesis/params.go Outdated Show resolved Hide resolved
command/genesis/polybft_params.go Show resolved Hide resolved
@begmaroman begmaroman merged commit fff84d1 into develop May 1, 2023
@begmaroman begmaroman deleted the feature/disable-eip-1559-if-burn-contract-is-not-provided branch May 1, 2023 13:27
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@vcastellm vcastellm vcastellm approved these changes

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@begmaroman begmaroman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@begmaroman @vcastellm @Stefan-Ethernal