Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint github workflow to trigger on every pull request #1526

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix lint github workflow to trigger on every pull request #1526

merged 1 commit into from
May 19, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

Fixes indentation in lint GH workflow and adds corresponding events to pull_request trigger.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label May 19, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this May 19, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Fix lint github workflow (2nd attempt) Fix lint github workflow to trigger on every pull request May 19, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review May 19, 2023 08:50
@Stefan-Ethernal Stefan-Ethernal merged commit d7a35c3 into develop May 19, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/lint-gh-external-collabs branch May 19, 2023 09:01
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

@Nemanja0x Nemanja0x Awaiting requested review from Nemanja0x

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stefan-Ethernal @vcastellm @igorcrevar @goran-ethernal