Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction relayer fetching gas price from current eth client instead of using hardcoded value #1589

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Transaction relayer fetching gas price from current eth client instead of using hardcoded value #1589

merged 8 commits into from
Jun 7, 2023

Conversation

dusan-maksimovic
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic commented Jun 6, 2023 •
edited
Loading

Description

Fixes issue 1551.

  • Transaction relayer SendTransaction() function is modified to fetch the gas price from the current client, if the gas price for the transaction wasn't set.
  • Setting the gas price explicitly on transactions before calling txRelayer.SendTransaction() was removed.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusan-maksimovic dusan-maksimovic added the bug fix Functionality that fixes a bug label Jun 6, 2023
@dusan-maksimovic dusan-maksimovic self-assigned this Jun 6, 2023
@dusan-maksimovic dusan-maksimovic mentioned this pull request Jun 6, 2023
Closed
11 tasks
@dusan-maksimovic dusan-maksimovic requested a review from a team June 7, 2023 08:12
@dusan-maksimovic dusan-maksimovic marked this pull request as ready for review June 7, 2023 08:13
@dusan-maksimovic dusan-maksimovic requested a review from a team June 7, 2023 08:46
vcastellm
vcastellm approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Stefan-Ethernal
Stefan-Ethernal approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we unexport DefaultGasPrice in txrelayer package? Other than that LGTM.

@dusan-maksimovic dusan-maksimovic merged commit 5318ff4 into develop Jun 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
@dusan-maksimovic dusan-maksimovic deleted the txrelayer-using-hardcoded-default-gas-limit branch June 7, 2023 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@dusan-maksimovic dusan-maksimovic

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction relayer using default value for gas limit instead of Current gas price of the network
6 participants
@dusan-maksimovic @vcastellm @igorcrevar @Stefan-Ethernal @goran-ethernal @adirola