Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate commitment bridge transactions for finalized blocks #1599

Merged
merged 9 commits into from
Jun 14, 2023
Merged

Validate commitment bridge transactions for finalized blocks #1599

merged 9 commits into from
Jun 14, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Jun 8, 2023 •
edited
Loading

Description

The PR introduces validation of bridge commitment transactions for finalized blocks as well. Verification includes checking quorum is reached and that signatures are valid.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Jun 8, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Jun 8, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-427-tob-edge-26-unclear-separation-of-responsibilities-between-systems-smart-contracts-and-validators-commitments branch from 1b893cb to 58361e1 Compare June 8, 2023 19:10
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-427-tob-edge-26-unclear-separation-of-responsibilities-between-systems-smart-contracts-and-validators-commitments branch from ad67dc5 to d77cfcb Compare June 9, 2023 06:00
@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 9, 2023 08:31
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review June 9, 2023 08:31
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-427-tob-edge-26-unclear-separation-of-responsibilities-between-systems-smart-contracts-and-validators-commitments branch from f56337b to b342c6b Compare June 9, 2023 08:37
vcastellm
vcastellm approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@Stefan-Ethernal Stefan-Ethernal merged commit 62bed80 into develop Jun 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-427-tob-edge-26-unclear-separation-of-responsibilities-between-systems-smart-contracts-and-validators-commitments branch June 14, 2023 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stefan-Ethernal @vcastellm @igorcrevar @goran-ethernal