Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-722]: Full nodes should not send votes for commitments #1682

Merged
merged 1 commit into from
Jul 3, 2023
Merged

[EVM-722]: Full nodes should not send votes for commitments #1682

merged 1 commit into from
Jul 3, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jun 29, 2023 •
edited
Loading

Description

This PR fixes the issue where full nodes sent votes for commitments.

Since full nodes can become validators at some point, saving state sync events is done on full nodes as well, but those nodes will not build nor vote for state sync commitments, until and if they become a validator.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Jun 29, 2023
@goran-ethernal goran-ethernal self-assigned this Jun 29, 2023
@goran-ethernal goran-ethernal requested a review from a team June 29, 2023 12:04
@goran-ethernal goran-ethernal force-pushed the EVM-722-Full-nodes-should-not-vote-on-commitments branch from 93af923 to af423dc Compare June 29, 2023 12:05
@goran-ethernal goran-ethernal force-pushed the EVM-722-Full-nodes-should-not-vote-on-commitments branch from af423dc to 32eae95 Compare June 29, 2023 12:08
vcastellm
vcastellm approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goran-ethernal goran-ethernal merged commit 655d15d into develop Jul 3, 2023
@goran-ethernal goran-ethernal deleted the EVM-722-Full-nodes-should-not-vote-on-commitments branch July 3, 2023 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stana-miric stana-miric stana-miric approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goran-ethernal @vcastellm @igorcrevar @stana-miric