Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track progression while syncing blocks #1985

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Track progression while syncing blocks #1985

merged 1 commit into from
Oct 19, 2023

Conversation

stana-miric
Copy link
Contributor

Description

This RP fixing progression tracking when syncing block in syncer. Earlier, progression instance existed in syncer, but was not used at all.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@stana-miric stana-miric added the bug fix Functionality that fixes a bug label Oct 12, 2023
@stana-miric stana-miric requested a review from a team October 12, 2023 13:10
@stana-miric stana-miric self-assigned this Oct 12, 2023
@stana-miric stana-miric marked this pull request as draft October 12, 2023 17:22
@stana-miric stana-miric force-pushed the EVM-529-improve-syncer-test-with-progression-testing branch from 2351bc8 to 3966eb1 Compare October 18, 2023 13:00
@stana-miric stana-miric marked this pull request as ready for review October 18, 2023 13:28
@stana-miric stana-miric merged commit 73469c6 into develop Oct 19, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-529-improve-syncer-test-with-progression-testing branch October 20, 2023 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

Assignees

@stana-miric stana-miric

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stana-miric @igorcrevar @Stefan-Ethernal @dusan-maksimovic