-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate polybft e2e framework to edge #797
Migrate polybft e2e framework to edge #797
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #797 +/- ##
====================================================
Coverage ? 46.48%
====================================================
Files ? 157
Lines ? 20803
Branches ? 0
====================================================
Hits ? 9670
Misses ? 10430
Partials ? 703 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9dbee94
to
60532bc
Compare
…-e-2-e-framework-to-edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but not sure if we should strive to consolidate existing edge framework with this one somewhere in the future?
And just not to forget: we need to port bridge test (and bridge e2e testing framework infrastructure).
Yeah, this should be our goal, but it will be out of the scope in this PR, we still have some work to do, but anyway, the existing e2e framework in edge is going to be removed at some point.
Same here, pending to do. |
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
…' of github.com:0xPolygon/polygon-edge into feature/EVM-78-migrate-poly-bft-e-2-e-framework-to-edge
…-e-2-e-framework-to-edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although it would be nice to address the some of the issues reported by gosec:
- [/github/workspace/e2e-polybft/framework/test-cluster.go:129] - G301 (CWE-276): Expect directory permissions to be 0750 or less (Confidence: HIGH, Severity: MEDIUM)
- [/github/workspace/e2e-polybft/framework/test-cluster.go:100] - G304 (CWE-22): Potential file inclusion via variable (Confidence: HIGH, Severity: MEDIUM)
- [/github/workspace/e2e-polybft/framework/test-cluster.go:100] - G302 (CWE-276): Expect file permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As Stefan said, it would be nice to fix those gosec errors. Not sure about these snyk tests, we can not see their execution 😕
Snyk tests are about some outdated dependencies we have in general across the repo, we'll need to address them in following PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
Backport the e2e framework + tests from v3 to edge.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Running in local