Implement the logic for quorum check #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #837 +/- ##
====================================================
Coverage ? 53.96%
====================================================
Files ? 158
Lines ? 21442
Branches ? 0
====================================================
Hits ? 11571
Misses ? 8924
Partials ? 947 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The solution looks good to me. |
vcastellm
requested review from
zivkovicmilos,
lazartravica,
Kourin1996,
dbrajovic,
0xAleksaOpacic and
ferranbt
as code owners
vcastellm
requested review from
goran-ethernal,
Nemanja0x,
Stefan-Ethernal,
b00ris and
begmaroman
b00ris
approved these changes
Nov 8, 2022
added 7 commits
November 8, 2022 10:31
Depending on the message type it will implement different kinds of quorum checks.
vcastellm
force-pushed
the
feature/move-quorum-to-edge
branch
from
5b2791f
to
45e79fa
Compare
added 2 commits
November 8, 2022 10:38
b00ris
approved these changes
Nov 8, 2022
Stefan-Ethernal
force-pushed
the
feature/v3-parity
branch
from
6ac164d
to
4afe707
Compare
Kourin1996
approved these changes
Nov 9, 2022
b00ris
approved these changes
Nov 10, 2022
Nemanja0x
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR goes together with 0xPolygon/go-ibft#39
Depending on the message type it will implement different kinds of quorum checks.
Changes include
Checklist
Testing
Manual tests
Local cluster can run fine.