Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkpointing] JSON RPC point for generating exit proofs #844

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[Checkpointing] JSON RPC point for generating exit proofs #844

merged 2 commits into from
Oct 31, 2022

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Oct 27, 2022 •
edited
Loading

Description

Added a new JSON RPC point for generating exit proofs.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal changed the title JSON RPC point for generating exit proofs [Checkpointing] JSON RPC point for generating exit proofs Oct 27, 2022
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Oct 27, 2022
@goran-ethernal goran-ethernal self-assigned this Oct 27, 2022
@goran-ethernal goran-ethernal marked this pull request as ready for review October 27, 2022 13:15
@codecov
Copy link

codecov bot commented Oct 27, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (EVM-84-Event-trie-storage-workflow@a6cbda3). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 34224d7 differs from pull request most recent head 61cebd5. Consider uploading reports for the commit 61cebd5 to get more accurate results

@@                          Coverage Diff                          @@
##             EVM-84-Event-trie-storage-workflow     #844   +/-   ##
=====================================================================
  Coverage                                      ?   53.32%           
=====================================================================
  Files                                         ?      161           
  Lines                                         ?    21314           
  Branches                                      ?        0           
=====================================================================
  Hits                                          ?    11365           
  Misses                                        ?     9038           
  Partials                                      ?      911

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

vcastellm
vcastellm approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Stefan-Ethernal
Stefan-Ethernal reviewed Oct 27, 2022
View reviewed changes
jsonrpc/bridge_endpoint.go Outdated Show resolved Hide resolved
consensus/consensus.go Outdated Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goran-ethernal goran-ethernal force-pushed the EVM-84-Event-trie-storage-workflow branch from 4b02a07 to a6cbda3 Compare October 31, 2022 08:52
@Stefan-Ethernal Stefan-Ethernal merged commit 213aa83 into EVM-84-Event-trie-storage-workflow Oct 31, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-90-Generate-Proof-RPC branch October 31, 2022 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@ferranbt ferranbt ferranbt approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@b00ris b00ris b00ris approved these changes

@vcastellm vcastellm vcastellm approved these changes

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

@lazartravica lazartravica Awaiting requested review from lazartravica

@dbrajovic dbrajovic Awaiting requested review from dbrajovic

@0xAleksaOpacic 0xAleksaOpacic Awaiting requested review from 0xAleksaOpacic

Assignees

@goran-ethernal goran-ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@goran-ethernal @vcastellm @b00ris @Kourin1996 @ferranbt @Stefan-Ethernal