Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assigned boot nodes port number in genesis #930

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Nov 18, 2022

Description

This PR fixes bootnodes port assignment changed through #912, which was wrong, because it assigned port numbers greater than 65536.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal self-assigned this Nov 18, 2022
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Nov 18, 2022
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/invalid_bootnode_ports_assigned branch from dc9369d to f08b185 Compare November 18, 2022 07:47
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review November 18, 2022 07:48
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #930 (f08b185) into feature/v3-parity (8627f12) will increase coverage by 0.01%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           feature/v3-parity     #930      +/-   ##
=====================================================
+ Coverage              53.77%   53.79%   +0.01%     
=====================================================
  Files                    162      162              
  Lines                  21676    21676              
=====================================================
+ Hits                   11657    11660       +3     
+ Misses                  9059     9057       -2     
+ Partials                 960      959       -1     
Impacted Files Coverage Δ
syncer/client.go 63.20% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stefan-Ethernal Stefan-Ethernal merged commit 4a3f562 into feature/v3-parity Nov 18, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the fix/invalid_bootnode_ports_assigned branch November 18, 2022 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants