Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/no overwrite timestamp #75

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Feature/no overwrite timestamp #75

merged 2 commits into from
Dec 1, 2022

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • avoid overwrite timestamp for the same globalExitRoot
  • add test to check above implementation
  • increase package.json version

@cla-bot cla-bot bot added the cla-signed label Nov 30, 2022
@krlosMata krlosMata marked this pull request as draft November 30, 2022 08:31
@krlosMata krlosMata force-pushed the feature/no-overwrite-timestamp branch from 0d1decf to edb3ffa Compare December 1, 2022 13:26
@krlosMata krlosMata marked this pull request as ready for review December 1, 2022 13:50
ignasirv
ignasirv approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata merged commit e25455d into develop Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlosMata @ignasirv