feat: add optional displayMethod to CredentialRequest #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmidyllic
previously approved these changes
Sep 5, 2024
Kolezhniuk
previously approved these changes
Sep 5, 2024
volodymyr-basiuk
dismissed stale reviews from Kolezhniuk and vmidyllic
via
7959ede
vmidyllic
previously approved these changes
Sep 5, 2024
Kolezhniuk
reviewed
Sep 5, 2024
src/credentials/credential-wallet.ts
Outdated
| @@ -265,11 +266,22 @@ export class CredentialWallet implements ICredentialWallet { | |||
| if (!schema.$metadata.uris['jsonLdContext']) { | |||
| throw new Error('jsonLdContext is missing is the schema'); | |||
| } | |||
| if (!request.context) { | |||
There was a problem hiding this comment.
request.context = request.context ?? []
Kolezhniuk
previously approved these changes
Sep 5, 2024
Kolezhniuk
approved these changes
Sep 5, 2024
vmidyllic
approved these changes
Sep 5, 2024
volodymyr-basiuk
added a commit
that referenced
this pull request
Sep 19, 2024
* feat: add optional displayMethod to CredentialRequest * IDEN3_DISPLAY_METHOD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.