chore: add type ZeroKnowledgeProofQuery to scope.query #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-basiuk
requested review from
amonsosanz,
Kolezhniuk and
vmidyllic
volodymyr-basiuk
changed the title
volodymyr-basiuk
changed the title
Kolezhniuk
previously approved these changes
Sep 27, 2024
vmidyllic
reviewed
Sep 30, 2024
vmidyllic
previously approved these changes
Sep 30, 2024
volodymyr-basiuk
dismissed stale reviews from vmidyllic and Kolezhniuk
via
c945356
* update cross-chain integration test * fix wrong tree state fullfilment * 1.20.2 * you are the most pretty one --------- Co-authored-by: vbasiuk <[email protected]>
amonsosanz
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
LGTM. With these changes, we can remove the ZkQuery type from the web wallet and other clients and directly use the type ZeroKnowledgeProofRequest from the SDK. Thx @volodymyr-basiuk!
vmidyllic
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated scope.query type according to documentation - https://iden3-communication.io/authorization/1.0/request/
Extended type from
did-resolverwith state info for DID Document (covers documentation properties - https://w3.org/TR/did-core/#did-document-properties)