Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prove Starks without constraints #1552

Merged
merged 21 commits into from
Mar 15, 2024
Merged

Prove Starks without constraints #1552

merged 21 commits into from
Mar 15, 2024

Conversation

4l0n50
Copy link
Contributor

@4l0n50 4l0n50 commented Mar 8, 2024

This PR enable to implement starks without constraints.

plonky2/src/recursion/recursive_verifier.rs Outdated Show resolved Hide resolved
plonky2/src/recursion/recursive_verifier.rs Outdated Show resolved Hide resolved
starky/src/lookup.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Outdated Show resolved Hide resolved
starky/src/proof.rs Outdated Show resolved Hide resolved
starky/src/lookup.rs Outdated Show resolved Hide resolved
starky/src/lookup.rs Outdated Show resolved Hide resolved
starky/src/stark.rs Outdated Show resolved Hide resolved
starky/src/stark.rs Outdated Show resolved Hide resolved
starky/src/verifier.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a couple of nits!

starky/src/lookup.rs Outdated Show resolved Hide resolved
starky/src/prover.rs Show resolved Hide resolved
starky/src/stark.rs Show resolved Hide resolved
@pgebheim
Copy link
Collaborator

Does this need to be raised against 0xPolygonZero/zk_evm instead of this repo?

@pgebheim pgebheim added this to the zk-continuations - Q1 2024 milestone Mar 11, 2024
@pgebheim pgebheim added the enhancement New feature or request label Mar 11, 2024
starky/src/lookup.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Outdated Show resolved Hide resolved
starky/src/permutation_stark.rs Show resolved Hide resolved
@Nashtare
Copy link
Collaborator

@4l0n50 Could you add an entry to the CHANGELOG as well? Thanks!

@4l0n50
Copy link
Contributor Author

4l0n50 commented Mar 14, 2024

Does this need to be raised against 0xPolygonZero/zk_evm instead of this repo?

It changes a little the the starky code and can be eventually used outside 0xPolygonZero/zk_evm, so I would say it goes here.

CHANGELOG.md Outdated Show resolved Hide resolved
starky/src/prover.rs Outdated Show resolved Hide resolved
starky/src/lookup.rs Outdated Show resolved Hide resolved
starky/src/lookup.rs Outdated Show resolved Hide resolved
starky/src/prover.rs Outdated Show resolved Hide resolved
starky/src/lookup.rs Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nashtare Nashtare enabled auto-merge (squash) March 15, 2024 11:38
@Nashtare Nashtare merged commit 4f8e631 into main Mar 15, 2024
5 checks passed
@Nashtare Nashtare deleted the prove_tables branch March 15, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants