Simplify types: remove option from CTL filters #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
requested review from
muursh,
wborgeaud and
Nashtare
as code owners
|
We might want to bump up a version number, because this is probably an incompatible change to the API. |
matthiasgoergens
force-pushed
the
matthias/remove-filter
branch
from
c8b967b
to
1fc7967
Compare
CTL filters can already express perfectly well the behaviour that we gave for `None`. No need to complicated anything. Plus some random lint fixes that clippy demanded..
matthiasgoergens
force-pushed
the
matthias/remove-filter
branch
from
1fc7967
to
0731fec
Compare
Nashtare
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks @matthiasgoergens, I agree it's cleaner to remove the notion of Optional filter here and just go with default instead. We'll include it in the next plonky2 release.
Also thank you for silencing clippy in parallel!
muursh
approved these changes
Apr 15, 2024
|
@matthiasgoergens starky v0.4.0 has been published, including these changes as well as compilation fix when AVX-512 instructions are enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTL filters can already express perfectly well the behaviour that we gave for
None. No need to complicate anything.