Fix all lint warnings #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this fixes a minor mistake in the FFT testing code, where `degree_padded` value was log2 of what it should have been, preventing a testing loop from executing.
NB: Changed the config in the gadgets/arithmetic_extension.rs::tests module which may change the test's meaning?
unzvfu
commented
Nov 12, 2021
dlubarov
reviewed
Nov 12, 2021
dlubarov
reviewed
Nov 12, 2021
|
(No other concerns here, LGTM pending William's feedback) |
wborgeaud
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Looks good to me, thanks for cleaning that up!
Also +1 on the zero-warnings policy. I've been wanting to make a PR to suppress all Clippy lints, but I've been waiting for a time without open PRs which hasn't happened in a while. I'll have a go at it and see if it doesn't cause too many conflicts with ongoing PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all of those annoying lint warnings we've been putting up with forever. :) Mostly the problems were caused by code that was in a crate but only used in tests. I went through each one and did what seemed like the logical thing in each case: delete, move/refactor, or tag with
#[cfg(test)].Sorry to pick on you @wborgeaud for the review of this boring PR, but I think most of the code I've deleted was yours and so you're best placed to say whether it should be kept and flagged with a
#[allow(dead_code)]instead.One other thing to note: I've included the unrelated
#![feature(asm_sym)]in this PR as a recent update to my compiler required it.Personally I am strongly in favour of maintaining a zero-warnings policy for committed code, since it makes it much easier to see when stuff I've written generates a new warning. Happy to consider dissenting opinions though of course.
CC: @dlubarov @nbgl This addresses our discussion of same earlier today.