Disable hop sources to avoid excess inaccuracy

0xProject · Nov 25, 2020 · 2c924bb · 2c924bb
1 parent b7a74c4
commit 2c924bb
Showing 1 changed file with 6 additions and 18 deletions.
diff --git a/packages/asset-swapper/src/utils/market_operation_utils/sampler_operations.ts b/packages/asset-swapper/src/utils/market_operation_utils/sampler_operations.ts
@@ -1026,15 +1026,9 @@ export class SamplerOperations {
                             });
                             return sushiOps;
                         case ERC20BridgeSource.CryptoCom:
-                            const cryptoComOps = [
-                                this.getCryptoComSellQuotes([takerToken, makerToken], takerFillAmounts),
-                            ];
-                            intermediateTokens.forEach(t => {
-                                cryptoComOps.push(
-                                    this.getCryptoComSellQuotes([takerToken, t, makerToken], takerFillAmounts),
-                                );
-                            });
-                            return cryptoComOps;
+                            // Currently we avoid intermediate swaps as in effect the price at sample time
+                            // is often arbed back to price parity with Uniswap/Sushi
+                            return this.getCryptoComSellQuotes([takerToken, makerToken], takerFillAmounts);
                         case ERC20BridgeSource.Kyber:
                             return getKyberReserveIdsForPair(takerToken, makerToken).map(reserveId =>
                                 this.getKyberSellQuotes(reserveId, makerToken, takerToken, takerFillAmounts),
@@ -1149,15 +1143,9 @@ export class SamplerOperations {
                             });
                             return sushiOps;
                         case ERC20BridgeSource.CryptoCom:
-                            const cryptoComOps = [
-                                this.getCryptoComBuyQuotes([takerToken, makerToken], makerFillAmounts),
-                            ];
-                            intermediateTokens.forEach(t => {
-                                cryptoComOps.push(
-                                    this.getCryptoComBuyQuotes([takerToken, t, makerToken], makerFillAmounts),
-                                );
-                            });
-                            return cryptoComOps;
+                            // Currently we avoid intermediate swaps as in effect the price at sample time
+                            // is often arbed back to price parity with Uniswap/Sushi
+                            return this.getCryptoComBuyQuotes([takerToken, makerToken], makerFillAmounts);
                         case ERC20BridgeSource.Kyber:
                             return getKyberReserveIdsForPair(takerToken, makerToken).map(reserveId =>
                                 this.getKyberBuyQuotes(reserveId, makerToken, takerToken, makerFillAmounts),