Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protocol fees from RFQ orders #45

Merged
merged 4 commits into from
Nov 24, 2020

Conversation

dorothy-zbornak
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak commented Nov 23, 2020

Description

  • We no longer take a protocol fee on RFQ orders.
  • RFQ orders now have a taker field.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dorothy-zbornak dorothy-zbornak marked this pull request as ready for review November 23, 2020 22:44
@dorothy-zbornak dorothy-zbornak force-pushed the feat/exchange-proxy/free-native-orders branch 2 times, most recently from bf72015 to 106ede4 Compare November 24, 2020 20:58
@dorothy-zbornak dorothy-zbornak changed the title Remove protocol fees from native orders, sometimes Remove protocol fees from RFQ orders Nov 24, 2020
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! RIP fees (~‾▿‾)~

@dorothy-zbornak dorothy-zbornak force-pushed the feat/exchange-proxy/free-native-orders branch from 106ede4 to cceb991 Compare November 24, 2020 23:06
@dorothy-zbornak dorothy-zbornak merged commit 7591e99 into development Nov 24, 2020
@dorothy-zbornak dorothy-zbornak deleted the feat/exchange-proxy/free-native-orders branch November 24, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants