TransformERC20: Fix selling entire ETH balance #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
requested review from
abandeali1,
hysz and
moodlezoup
as code owners
dorothy-zbornak
force-pushed
the
fix/ep-transform-erc20/eth-sell-all-revert
branch
from
a9a6494
to
1432bec
Compare
…elling taker's entire balance when input token is ETH
dorothy-zbornak
force-pushed
the
fix/ep-transform-erc20/eth-sell-all-revert
branch
from
1432bec
to
92a1fba
Compare
dorothy-zbornak
deleted the
fix/ep-transform-erc20/eth-sell-all-revert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
TransformERC20Feature, wheninputTokenAmount == uint256(-1), we interpret this as trying to sell the taker's entire available balance. But we did not check if the input token was ETH. This causes reverts because0xeeeee...is not a token. Now we just setinputTokenAmount = msg.valuewhen ETH is being sold andinputTokenAmount == uint256(-1).Testing instructions
Types of changes
Checklist:
[WIP]if necessary.