Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFQ order with 0 txOrigin is INVALID #50

Merged
merged 2 commits into from
Nov 25, 2020
Merged

RFQ order with 0 txOrigin is INVALID #50

merged 2 commits into from
Nov 25, 2020

Conversation

smarx
Copy link
Contributor

@smarx smarx commented Nov 25, 2020 •
edited
Loading

Description

getRfqOrderInfo() now returns a status of INVALID for an order that has txOrigin == 0.

Testing instructions

yarn test

Types of changes

  • Bug fix

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

hysz
hysz approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, let's merge! (~‾▿‾)(~‾▿‾)(~‾▿‾)~

@smarx smarx merged commit 9653eb9 into development Nov 25, 2020
@smarx smarx deleted the fix/zero-origin-invalid branch November 25, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hysz hysz hysz approved these changes

@abandeali1 abandeali1 Awaiting requested review from abandeali1

@dorothy-zbornak dorothy-zbornak Awaiting requested review from dorothy-zbornak

@moodlezoup moodlezoup Awaiting requested review from moodlezoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarx @hysz