@0x/protocol-utils
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
requested review from
abandeali1,
hysz and
moodlezoup
as code owners
…-ex` + misc stuff
dorothy-zbornak
force-pushed
the
feat/protocol-utils
branch
from
367366f
to
da5a4e9
Compare
moodlezoup
approved these changes
Dec 9, 2020
| @@ -0,0 +1,71 @@ | |||
| ## @0x/protocol-utils | |||
|
|
|||
| 0x protocol-related utilities for the V4/Exchange Proxy constellation of contracts, with tooling related to: | |||
There was a problem hiding this comment.
constellation, I like it
dorothy-zbornak
force-pushed
the
feat/protocol-utils
branch
from
5001acb
to
f60574d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors all the user-facing tooling out of
@0x/contracts-zero-exinto a new package@0x/protocol-utils. It contains tooling for the V4/EP version of:TODO
signTypedDataV4Async()when Add support foreth_signTypedData_v4(meta-mask) tools#13 is merged.@0x/order-utilsto completely remove that dep from@0x/contracts-zero-ex. Can probably punt on this till when we expect to use mtxs again.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.