Add mtx tooling to @0x/protocol-utils
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
commented
Dec 16, 2020
| @@ -61,6 +61,7 @@ | |||
| "@0x/contracts-gen": "^2.0.24", | |||
| "@0x/contracts-test-utils": "^5.3.15", | |||
| "@0x/dev-utils": "^4.1.3", | |||
| "@0x/order-utils": "^10.4.10", | |||
There was a problem hiding this comment.
We are so close to losing this dep. 🤞
dorothy-zbornak
requested review from
abandeali1,
hysz and
moodlezoup
as code owners
moodlezoup
approved these changes
Dec 16, 2020
| it('can get the EIP712 hash', () => { | ||
| const actual = mtx.getHash(); | ||
| const expected = '0x068f2f98836e489070608461768bfd3331128787d09278d38869c2b56bfc34a4'; | ||
| expect(actual).to.deep.eq(expected); |
There was a problem hiding this comment.
Suggested change
| expect(actual).to.deep.eq(expected); | |
| expect(actual).to.eq(expected); |
packages/protocol-utils/src/mtx.ts
Outdated
| feeToken: NULL_ADDRESS, | ||
| feeAmount: ZERO, | ||
| chainId: 1, | ||
| verifyingContract: '0xdef1c0ded9bec7f1a1670819833240f027b25eff', |
There was a problem hiding this comment.
nit: pull this from contract-addresses?
dorothy-zbornak
force-pushed
the
feat/protocol-utils-mtx-utils
branch
from
4860a73
to
b27e122
Compare
meeting you halfway and going with |
…isc review feedback
dorothy-zbornak
force-pushed
the
feat/protocol-utils-mtx-utils
branch
from
b27e122
to
fc43984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
+ some refactors to reduce code dupe.
TODO
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.