Merge pull request #35 from 0xProject/fix/utils/address-utils

Fix `addressUtils.generatePseudoRandomAddress()
0xProject · Apr 26, 2021 · 3234949 · 3234949
2 parents 431f685 + 003e498
commit 3234949
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/utils/CHANGELOG.json b/utils/CHANGELOG.json
@@ -1,4 +1,13 @@
 [
+    {
+        "version": "6.4.1",
+        "changes": [
+            {
+                "note": "Fix `addressUtils.generatePseudoRandomAddress()`",
+                "pr": 35
+            }
+        ]
+    },
     {
         "version": "6.4.0",
         "changes": [

diff --git a/utils/src/address_utils.ts b/utils/src/address_utils.ts
@@ -1,8 +1,7 @@
-import { addHexPrefix, isValidChecksumAddress, keccak256, stripHexPrefix, toBuffer } from 'ethereumjs-util';
+import { addHexPrefix, isValidChecksumAddress, stripHexPrefix } from 'ethereumjs-util';
+import { hexUtils } from './hex_utils';
 import * as _ from 'lodash';
 
-import { generatePseudoRandom256BitNumber } from './random';
-
 const BASIC_ADDRESS_REGEX = /^(0x)?[0-9a-f]{40}$/i;
 const SAME_CASE_ADDRESS_REGEX = /^(0x)?([0-9a-f]{40}|[0-9A-F]{40})$/;
 const ADDRESS_LENGTH = 40;
@@ -28,10 +27,6 @@ export const addressUtils = {
         return addHexPrefix(_.padStart(stripHexPrefix(address), ADDRESS_LENGTH, '0'));
     },
     generatePseudoRandomAddress(): string {
-        const randomBigNum = generatePseudoRandom256BitNumber();
-        const randomBuff = keccak256(toBuffer(randomBigNum));
-        const addressLengthInBytes = 20;
-        const randomAddress = `0x${randomBuff.slice(0, addressLengthInBytes).toString('hex')}`;
-        return randomAddress;
+        return hexUtils.random(20);
     },
 };