Strip comments before looking for imports with regexes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
approved these changes
Feb 17, 2021
|
published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we search for dependencies with regexes - we sometimes accidentally catch the commented out imports.
This PR fixes that.
Ideally - we would use a parser and operate on an AST (there is a TODO in code for that), but this seems to solve the problem for now
Testing instructions
Try compiling https://etherscan.io/address/0x6b175474e89094c44da98b954eedeac495271d0f#code
Before: Fails on a commented out import
After: Succeeds
Types of changes
Checklist:
[WIP]if necessary.