Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix solc 0.8 support #61

Merged
merged 3 commits into from
Mar 16, 2022
Merged

fix solc 0.8 support #61

merged 3 commits into from
Mar 16, 2022

Conversation

dorothy-zbornak
Copy link
Contributor

Description

Actually compiling with 0.8 results in

TypeError: Cannot read property 'slice' of undefined

so let's upgrade the solc dep to the latest and use the new interface.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dorothy-zbornak dorothy-zbornak marked this pull request as ready for review March 16, 2022 05:27
dorothy-zbornak
dorothy-zbornak commented Mar 16, 2022
View reviewed changes
Copy link
Contributor Author

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, lawrence

@dorothy-zbornak dorothy-zbornak merged commit 343b40d into development Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekz dekz Awaiting requested review from dekz

@moodlezoup moodlezoup Awaiting requested review from moodlezoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorothy-zbornak @merklejerk