Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug allowUnlimitedContractSize not exist in ganache #89

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix bug allowUnlimitedContractSize not exist in ganache #89

wants to merge 1 commit into from

Conversation

graykode
Copy link

@graykode graykode commented Feb 15, 2023 •
edited
Loading

Description

I found out of gas in some tests: 0xProject/protocol#663 and It's because allowUnlimitedContractSize is not set in ganache provider. @dekz

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@graykode graykode requested a review from dekz as a code owner February 15, 2023 07:33
@graykode graykode mentioned this pull request Feb 15, 2023
Closed
3 tasks
@graykode
Copy link
Author

graykode commented Mar 2, 2023

Can you review this? @dekz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekz dekz Awaiting requested review from dekz dekz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@graykode