Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Add L1 to L2 message mock endpoint #365

Merged
merged 35 commits into from
Dec 15, 2022
Merged

Add L1 to L2 message mock endpoint #365

merged 35 commits into from
Dec 15, 2022

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Dec 8, 2022 •
edited
Loading

Usage related changes

  • L1 to L2 mock endpoint added /postman/l1_to_l2.

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@mikiw mikiw marked this pull request as draft December 8, 2022 15:58
@mikiw mikiw linked an issue Dec 8, 2022 that may be closed by this pull request
Add endpoints for sending/consuming messages #348
Closed
@mikiw mikiw requested a review from FabijanC December 9, 2022 09:49
@FabijanC FabijanC marked this pull request as ready for review December 9, 2022 09:50
FabijanC
FabijanC suggested changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the idea of this to just put a message into the message channel (which are handled by calling /flush), or to create and execute a transaction? Also, isn't this PR expected to introduce both a send and a consume method? @maciejka can you please give your feedback?

starknet_devnet/blueprints/postman.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/postman.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/postman.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/postman.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
@mikiw mikiw requested a review from FabijanC December 14, 2022 14:51
FabijanC
FabijanC suggested changes Dec 14, 2022
View reviewed changes
page/docs/guide/postman.md Show resolved Hide resolved
page/docs/guide/postman.md Show resolved Hide resolved
starknet_devnet/blueprints/postman.py Outdated Show resolved Hide resolved
page/docs/guide/postman.md Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
FabijanC
FabijanC suggested changes Dec 15, 2022
View reviewed changes
starknet_devnet/blueprints/postman.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/postman.py Show resolved Hide resolved
starknet_devnet/blueprints/postman.py Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit dfd1ccb into master Dec 15, 2022
@FabijanC FabijanC deleted the l1-l2-endpoints branch December 15, 2022 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add endpoints for sending/consuming messages
2 participants
@mikiw @FabijanC