-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
@THenry14 Thanks for the PR! As you can see, the testing workflows have failed. I will probably review the PR next week after you have fixed this. |
Oh, I'm sorry for that - I have run the linter, but then rebased and missed one unused import. I have addressed that in the newest commit, the tests should pass now 👍 edit: I can see they failed on "Check out previous test metadata" step, not sure what it does and if it's connected to the code at all |
Thanks for fixing the linter issue. What we have now is most likely a CircleCI issue, I will check it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CircleCI issue doesn't seem to be resolvable from my end. The downloading of previous test results (for splitting between workers) doesn't seem to be executed (file not present in a later check step). I tried writing a report on CircleCI's discussion forum only to get my post marked as spam for providing too many links 🤣 .
Anyway, thank you for raising the quality of Devnet's code, just left some minor comments.
Usage related changes
Fixed some problems with rpc
get_events
:from_block
andto_block
are now accepted as block_hashesfrom_block
andto_block
format in payload, so it now reflects the rpc specThere is still a probllem with (in my opinion) a bug in rpc schema regarding Felts (they are in
"^0x0[a-fA-F0-9]{1,63}$"
format, that is different to gateway), that's why I had to wrap test data withrpc_felt
. From what I know, the discussion is already opened with starkware cairo team to resolve this.Checklist:
./scripts/format.sh
./scripts/lint.sh
./scripts/test.sh