Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Starkscan compatibility #397

Merged
merged 33 commits into from
Feb 21, 2023
Merged

Starkscan compatibility #397

merged 33 commits into from
Feb 21, 2023

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Feb 13, 2023 •
edited by FabijanC
Loading

Usage related changes

  • Starkscan genesis block compatibility was added

Development related changes

  • Genesis block related tests have been changed
  • Rename OZ_ACCOUNT_CLASS_HASH to STARKNET_CLI_ACCOUNT_CLASS_HASH

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@mikiw mikiw marked this pull request as draft February 13, 2023 14:00
@mikiw mikiw linked an issue Feb 17, 2023 that may be closed by this pull request
StarkScan compatibility #369
Closed
@mikiw mikiw marked this pull request as ready for review February 20, 2023 14:53
@mikiw mikiw requested a review from FabijanC February 20, 2023 14:53
FabijanC
FabijanC suggested changes Feb 20, 2023
View reviewed changes
starknet_devnet/blocks.py Outdated Show resolved Hide resolved
page/docs/guide/blocks.md Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Show resolved Hide resolved
test/test_block_genesis.py Outdated Show resolved Hide resolved
test/test_block_genesis.py Outdated Show resolved Hide resolved
test/test_block_genesis.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Show resolved Hide resolved
@FabijanC FabijanC merged commit e54507e into master Feb 21, 2023
@FabijanC FabijanC deleted the starkscan-compatibility branch February 21, 2023 13:01
@mikiw mikiw mentioned this pull request Apr 2, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StarkScan compatibility
2 participants
@mikiw @FabijanC