Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

increase/set time block creation #416

Merged
merged 17 commits into from
Mar 9, 2023
Merged

increase/set time block creation #416

merged 17 commits into from
Mar 9, 2023

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Mar 3, 2023 •
edited
Loading

Usage related changes

  • from now on POST functions /increase_time and /set_time will change the timestamp and generate a block, in --blocks-on-demand mode pending transactions will be included

Development related changes

  • update_pending_state function in StarknetWrapper class is now public
  • 2 new timestamp tests were introduced and some of them were refactored

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@mikiw mikiw marked this pull request as draft March 3, 2023 11:17
@mikiw
quickfix
663c820 
[skip ci]
@mikiw mikiw changed the title Time block creation increase/set time block creation Mar 3, 2023
@mikiw mikiw linked an issue Mar 3, 2023 that may be closed by this pull request
Apply timestamp setting prior to block/transaction creation (not after) #216
Closed
@mikiw mikiw marked this pull request as ready for review March 7, 2023 09:50
@mikiw mikiw requested a review from FabijanC March 7, 2023 09:50
FabijanC
FabijanC suggested changes Mar 7, 2023
View reviewed changes
test/test_timestamps.py Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
page/docs/guide/advancing-time.md Outdated Show resolved Hide resolved
page/docs/guide/advancing-time.md Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
test/test_blocks_on_demand.py Outdated Show resolved Hide resolved
FabijanC
FabijanC reviewed Mar 8, 2023
View reviewed changes
page/docs/guide/advancing-time.md Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
@mikiw mikiw requested a review from FabijanC March 8, 2023 17:01
@FabijanC FabijanC merged commit 153acbb into master Mar 9, 2023
@FabijanC FabijanC deleted the time-block-creation branch March 9, 2023 11:21
@FabijanC FabijanC mentioned this pull request Oct 26, 2023
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply timestamp setting prior to block/transaction creation (not after)
2 participants
@mikiw @FabijanC