Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Abort blocks #421

Merged
merged 91 commits into from
Apr 26, 2023
Merged

Abort blocks #421

merged 91 commits into from
Apr 26, 2023

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Mar 20, 2023 •
edited
Loading

Usage related changes

  • Add /abort_blocks_after endpoint which can abort blocks and transactions from a given block to the latest block

Development related changes

  • abort_block_by_hash() and reject_transaction() functions added
  • new tests to the abort block functionality were introduced

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@mikiw mikiw marked this pull request as draft March 20, 2023 09:18
@mikiw
refactor
c163989 
[skip ci]
@mikiw
refactor and new test
0f57ed4 
[skip ci]
@mikiw
refactor
1cf0df8 
[skip ci]
@mikiw mikiw linked an issue Mar 20, 2023 that may be closed by this pull request
Add a command to abort blocks #417
Closed
@mikiw
Copy link
Contributor Author

mikiw commented Mar 20, 2023 •
edited
Loading

TODO:

  • discuss transaction_receipts hack during PR

@mikiw mikiw marked this pull request as ready for review March 29, 2023 09:57
@mikiw mikiw requested a review from FabijanC March 29, 2023 09:57
FabijanC
FabijanC suggested changes Mar 29, 2023
View reviewed changes
test/test_abort_blocks_after.py Outdated Show resolved Hide resolved
test/test_abort_blocks_after.py Outdated Show resolved Hide resolved
test/test_abort_blocks_after.py Outdated Show resolved Hide resolved
test/test_abort_blocks_after.py Show resolved Hide resolved
test/test_abort_blocks_after.py Outdated Show resolved Hide resolved
page/docs/guide/abort-blocks.md Outdated Show resolved Hide resolved
page/docs/guide/abort-blocks.md Outdated Show resolved Hide resolved
starknet_devnet/blocks.py Outdated Show resolved Hide resolved
starknet_devnet/blocks.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
@mikiw mikiw requested a review from FabijanC April 25, 2023 14:03
@mikiw mikiw changed the title Abort blocks after Abort blocks Apr 26, 2023
FabijanC
FabijanC reviewed Apr 26, 2023
View reviewed changes
starknet_devnet/blocks.py Outdated Show resolved Hide resolved
FabijanC
FabijanC reviewed Apr 26, 2023
View reviewed changes
starknet_devnet/blocks.py Outdated Show resolved Hide resolved
@mikiw
Copy link
Contributor Author

mikiw commented Apr 26, 2023

I added a fix with exception instead of HTTP 200 e01c3ed

@FabijanC FabijanC merged commit ad95cc4 into master Apr 26, 2023
@FabijanC FabijanC deleted the abort-blocks-after branch April 26, 2023 15:48
@mikiw mikiw mentioned this pull request Feb 28, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a command to abort blocks
2 participants
@mikiw @FabijanC