Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Internal error on get_full_contract #442

Merged
merged 15 commits into from
Apr 14, 2023
Merged

Internal error on get_full_contract #442

merged 15 commits into from
Apr 14, 2023

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Apr 12, 2023 •
edited
Loading

Usage related changes

  • Bugfix of UDC deployment nad get_full_contract()

Development related changes

  • Fix missing set of contract_classes for UDC invoke

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@mikiw mikiw linked an issue Apr 12, 2023 that may be closed by this pull request
Internal error on get_full_contract #441
Closed
2 tasks
@mikiw mikiw marked this pull request as draft April 12, 2023 14:01
@mikiw mikiw changed the title Get full contract problem Internal error on get_full_contract Apr 12, 2023
@mikiw mikiw marked this pull request as ready for review April 13, 2023 10:06
@mikiw mikiw requested a review from FabijanC April 13, 2023 10:44
FabijanC
FabijanC suggested changes Apr 13, 2023
View reviewed changes
test/util.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit ef241a1 into master Apr 14, 2023
@FabijanC FabijanC deleted the get-full-contract-problem branch April 14, 2023 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal error on get_full_contract
2 participants
@mikiw @FabijanC