Make walletConnect an optional connector (#158)

0xsequence · Oct 2, 2024 · eb23934 · eb23934
1 parent 4da16ba
commit eb23934
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 18 deletions.
diff --git a/README.md b/README.md
@@ -61,7 +61,7 @@ interface CreateConfigOptions {
   // optional wagmiConfig overrides
   wagmiConfig?: WagmiConfig
 
-  walletConnectProjectId: string
+  walletConnectProjectId?: string
 
   // embedded wallet (waas) specific connector options
   waasConfigKey: string

diff --git a/packages/kit/README.md b/packages/kit/README.md
@@ -60,7 +60,7 @@ interface CreateConfigOptions {
   // optional wagmiConfig overrides
   wagmiConfig?: WagmiConfig
 
-  walletConnectProjectId: string
+  walletConnectProjectId?: string
 
   // embedded wallet (waas) specific connector options
   waasConfigKey: string

diff --git a/packages/kit/src/config/defaultConnectors.ts b/packages/kit/src/config/defaultConnectors.ts
@@ -17,8 +17,8 @@ import { getKitConnectWallets } from '../utils/getKitConnectWallets'
 export interface CommonConnectorOptions {
   appName: string
   projectAccessKey: string
-  walletConnectProjectId: string
   defaultChainId?: number
+  walletConnectProjectId?: string
 }
 
 export interface DefaultWaasConnectorOptions extends CommonConnectorOptions {
@@ -48,8 +48,8 @@ export const getDefaultConnectors = <T extends WalletType>(walletType: T, option
 export const getDefaultWaasConnectors = ({
   appName,
   projectAccessKey,
-  walletConnectProjectId,
   defaultChainId,
+  walletConnectProjectId,
 
   waasConfigKey,
   googleClientId,
@@ -70,11 +70,17 @@ export const getDefaultWaasConnectors = ({
     }),
     coinbaseWallet({
       appName
-    }),
-    walletConnect({
-      projectId: walletConnectProjectId
     })
   ]
+
+  if (walletConnectProjectId) {
+    wallets.push(
+      walletConnect({
+        projectId: walletConnectProjectId
+      })
+    )
+  }
+
   if (googleClientId) {
     wallets.push(
       googleWaas({
@@ -87,6 +93,7 @@ export const getDefaultWaasConnectors = ({
       })
     )
   }
+
   if (appleClientId && appleRedirectURI) {
     wallets.push(
       appleWaas({
@@ -101,18 +108,16 @@ export const getDefaultWaasConnectors = ({
     )
   }
 
-  const connectors = getKitConnectWallets(projectAccessKey, wallets)
-
-  return connectors
+  return getKitConnectWallets(projectAccessKey, wallets)
 }
 
 export const getDefaultUniversalConnectors = ({
   appName,
   projectAccessKey,
-  walletConnectProjectId,
-  defaultChainId
+  defaultChainId,
+  walletConnectProjectId
 }: DefaultUniversalConnectorOptions): CreateConnectorFn[] => {
-  const connectors = getKitConnectWallets(projectAccessKey, [
+  const wallets: any[] = [
     email({
       defaultNetwork: defaultChainId,
       connect: {
@@ -148,11 +153,16 @@ export const getDefaultUniversalConnectors = ({
       connect: {
         app: appName
       }
-    }),
-    walletConnect({
-      projectId: walletConnectProjectId
     })
-  ])
+  ]
+
+  if (walletConnectProjectId) {
+    wallets.push(
+      walletConnect({
+        projectId: walletConnectProjectId
+      })
+    )
+  }
 
-  return connectors
+  return getKitConnectWallets(projectAccessKey, wallets)
 }