Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add semicolon at the end of self-invoking function #129

Merged
merged 1 commit into from
Apr 5, 2022
Merged

refactor: add semicolon at the end of self-invoking function #129

merged 1 commit into from
Apr 5, 2022

Conversation

lelinhtinh
Copy link
Contributor

Safely concatenate. Ref: airbnb/javascript#44 (comment)
Actual error case: Tampermonkey/tampermonkey#595

@lelinhtinh lelinhtinh closed this Apr 5, 2022
@lelinhtinh lelinhtinh deleted the bugfix/missing-semicolon-bugfix branch April 5, 2022 09:53
@lelinhtinh lelinhtinh restored the bugfix/missing-semicolon-bugfix branch April 5, 2022 09:54
@lelinhtinh lelinhtinh reopened this Apr 5, 2022
@101arrowz
Copy link
Owner

I'll merge this, but I feel like some issues could still arise. Wouldn't xfetch, which was referenced in the Tampermonkey issue, still fail if concatenated with fflate unless a newline is used to separate them?

@101arrowz 101arrowz merged commit 80c12de into 101arrowz:master Apr 5, 2022
@lelinhtinh lelinhtinh deleted the bugfix/missing-semicolon-bugfix branch April 13, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants