Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Prendre en compte la whitelist des URLs dans la moulinette (PIX-6043) #792

Conversation

laura-bergoens
Copy link
Member

@laura-bergoens laura-bergoens commented Oct 25, 2024

🦄 Problème

Pour la moulinette, il y a des URLs qu'on sait KO de base et qu'on souhaiterait ignorer dans le fichier de résultat pour faire moins de bruit.
On a une PR pour mettre en place une interface de gestion des urls à whitelister.
Maintenant l'idée c'est de prendre en compte cette liste dans le job.

🤖 Proposition

Prendre les urls whitelistées actives
En tenir compte dans la moulinette (avec les deux types de check, exact match ou starts with)

🌈 Remarques

Dépend de la PR pour l'interface de gestion

💯 Pour tester

Tester de lancer le job avec des urls whitelistée

@laura-bergoens laura-bergoens self-assigned this Oct 25, 2024
@laura-bergoens laura-bergoens added the team-contenu L'équipe contenu label Oct 25, 2024
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://pix-lcms-review-pr792.osc-fr1.scalingo.io
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-lcms-review-pr792/environment

@laura-bergoens laura-bergoens force-pushed the pix-6043-take-into-account-url-whitelist-in-moulinette-url branch from 41f5458 to 4119b25 Compare October 25, 2024 08:44
@fael-b fael-b force-pushed the pix-11737-allow-admin-to-handle-urls-whitelist-for-moulinette-urls-cassés branch from 193c605 to ec7b65d Compare October 25, 2024 13:36
@laura-bergoens laura-bergoens force-pushed the pix-11737-allow-admin-to-handle-urls-whitelist-for-moulinette-urls-cassés branch 3 times, most recently from d086966 to dccdb37 Compare November 4, 2024 16:17
@laura-bergoens laura-bergoens force-pushed the pix-6043-take-into-account-url-whitelist-in-moulinette-url branch from 4119b25 to 02d8edf Compare November 13, 2024 10:29
@laura-bergoens laura-bergoens changed the base branch from pix-11737-allow-admin-to-handle-urls-whitelist-for-moulinette-urls-cassés to pix-15183-edit-whitelisted-url November 13, 2024 10:29
@laura-bergoens laura-bergoens force-pushed the pix-6043-take-into-account-url-whitelist-in-moulinette-url branch from 02d8edf to 596c0fa Compare November 13, 2024 10:31
@laura-bergoens laura-bergoens marked this pull request as ready for review November 13, 2024 10:34
@laura-bergoens laura-bergoens force-pushed the pix-6043-take-into-account-url-whitelist-in-moulinette-url branch from 596c0fa to 36589a5 Compare November 13, 2024 10:37
@laura-bergoens laura-bergoens force-pushed the pix-15183-edit-whitelisted-url branch 2 times, most recently from 67f1cc6 to 0dadb6d Compare November 13, 2024 14:17
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://pix-lcms-review-pr792.osc-fr1.scalingo.io
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-lcms-review-pr792/environment

Base automatically changed from pix-15183-edit-whitelisted-url to dev November 13, 2024 14:37
@laura-bergoens laura-bergoens force-pushed the pix-6043-take-into-account-url-whitelist-in-moulinette-url branch from 36589a5 to c4883a4 Compare November 13, 2024 14:37
Copy link
Member

@nlepage nlepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

api/lib/domain/models/WhitelistedUrl.js Outdated Show resolved Hide resolved
api/lib/domain/usecases/validate-urls-from-release.js Outdated Show resolved Hide resolved
api/lib/domain/usecases/validate-urls-from-release.js Outdated Show resolved Hide resolved
@laura-bergoens laura-bergoens force-pushed the pix-6043-take-into-account-url-whitelist-in-moulinette-url branch from c4883a4 to f7d4706 Compare November 14, 2024 09:00
@pix-service-auto-merge pix-service-auto-merge merged commit 42df125 into dev Nov 14, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants