Esacape shell args to allow paths with spaces. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esiegel
commented
Dec 31, 2023
| @@ -1,5 +1,59 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| echo "-----------RUNNING MOCK LOUPER EXECUTABLE--------------" | |||
There was a problem hiding this comment.
bash script now verifies that the arguments passed in are valid
esiegel
commented
Dec 31, 2023
| @@ -1,5 +1,66 @@ | |||
| @echo off | |||
|
|
|||
| echo "-----------RUNNING MOCK LOUPER.BAT EXECUTABLE--------------" | |||
| echo Arguments passed to the script: %* | |||
There was a problem hiding this comment.
batch script verifies arguments
esiegel
commented
Dec 31, 2023
| :parse_args | ||
| if "%~1" equ "" goto :check_paths | ||
|
|
||
| if /i "%~1" equ "--input" ( |
There was a problem hiding this comment.
The "%~1" will strip any surrounding quotes around the argument, but it seems to do wonky things depending on if there is a space between the equal sign. --output="some path"vs--output = "some apth"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix the issue on windows where output paths with spaces are causing bad inputs to the executable. It seems that using the
normalizePathfunction on windows will convert relative paths to absolute paths, where on MacOS this isn't the case. This is why the issue of spaces in paths only has been reported by windows users.