Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action.yml #3

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update action.yml #3

merged 1 commit into from
Mar 19, 2024

Conversation

jdevalk
Copy link
Contributor

@jdevalk jdevalk commented Jan 23, 2024

Description of the Change

  1. Make id more descriptive so there's less chance of a name clash.
  2. Update to version 4 of the upload-artifact action, as that brings with it the rather cool option to get the artifact URL immediately.

Closes #2

How to test the Change

Not 100% sure :)

Changelog Entry

Updated to v4 of upload-artifact, the action now exposes the artifact URL with: ${{ steps.upload-plugin-artifact.outputs.artifact-url }}

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

1. Make `id` more descriptive so there's less chance of a name clash. 
2. Update to version 4 of the `upload-artifact` action, as [that brings with it the rather cool option to get the artifact URL immediately](actions/upload-artifact#50 (comment)).
@dkotter dkotter self-requested a review January 24, 2024 15:38
@dkotter dkotter added this to the 1.1.0 milestone Jan 24, 2024
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me

@hansmorb
Copy link

hansmorb commented Mar 18, 2024

I would also like to see this merged, is there anything I can do to make it happen?

Edit: Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL of the zip file
4 participants