Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #46

Closed
7 tasks done
adamsilverstein opened this issue Oct 16, 2019 · 7 comments
Closed
7 tasks done

Release 1.0.0 #46

adamsilverstein opened this issue Oct 16, 2019 · 7 comments
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@adamsilverstein
Copy link

adamsilverstein commented Oct 16, 2019

Continues #34

  • Merge: Make a non-fast-forward merge from your release branch to develop, then do the same for develop into master. master contains the stable development version.
  • Push: Push your master branch to GitHub, e.g. git push origin master.
  • Wait for build: Head to the Actions tab in the repo and wait for it to finish if it hasn't already. If it doesn't succeed, figure out why and start over.
  • Check the build: Check out the stable branch and test for functionality locally.
  • Git tag: Create the release as 1.0.0 on the stable branch in GitHub. It should now appear under releases and in the WordPress admin as an update as well.
  • Edit the 1.0.0 milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close 1.0.0 milestone
  • If any open issues or PRs which were milestoned for 1.0.0 do not make it into the release, update their milestone to 1.1.0 or Future Release
@adamsilverstein adamsilverstein added the type:enhancement New feature or request. label Oct 16, 2019
@adamsilverstein adamsilverstein added this to the 1.0.0 milestone Oct 16, 2019
@adamsilverstein adamsilverstein self-assigned this Oct 16, 2019
@jeffpaul
Copy link
Member

Confirming a Slack conversation with @johnwatkins0 that we both feel we're ready for a v1 release. As this is our initial release, we'll do so here first on GitHub and then submit the ZIP to the Plugin Review team on .ORG and await their review before this officially hits the .ORG repo.

@johnwatkins0
Copy link
Member

Ready to go, @jeffpaul . The only thing is the GH deploy action failed, which I assume is expected because the .org repo doesn't exist yet: https://github.com/10up/autoshare-for-twitter/commit/e61b2cac151e5fafc5b0a3cdab0fb3c679df865e/checks

@jeffpaul
Copy link
Member

@johnwatkins0 we'll want to confirm the release ZIP file contains only the files needed to submit to .ORG, once you can confirm that we'll submit to the Plugin Review team and await their response.

@johnwatkins0
Copy link
Member

@jeffpaul Just to make sure I understand the process here -- for this initial release to .ORG, we need a copy of the plugin that doesn't have the unneeded files and does have the built assets and production dependencies (as opposed to the the zip automatically attached to the GitHub release, which contains the source code from the released branch). Future releases can be handled by the plugin deploy action, but this first one is manual. Do I have this right?

@jeffpaul
Copy link
Member

@johnwatkins0 completely correct, yep!

@johnwatkins0
Copy link
Member

Hey, @jeffpaul . Here's a zip that contains what's needed and only what's needed for the plugin to run. Let me know if this does the trick.

autoshare-for-twitter.zip

@jeffpaul
Copy link
Member

I added in the readme.txt and submitted to .ORG, we're currently 15th in line for review so I'm not expecting to hear back until mid-January. I'll go ahead and close the 1.0.0 milestone and we can start looking at enhancements for a next release to milestone (alongside anything the .ORG Plugin Review team asks for).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants