Prep for 1.0.0 release #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #4. |
@todo confirm libraries to include
|
jeffpaul
commented
Sep 12, 2019
jeffpaul
commented
Sep 12, 2019
|
@adamsilverstein made those changes, plus applied the description/license updates in other areas across the plugin. Likely some merge conflicts we need to review later with the plugin renaming changes, will worry about that post-summit. |
|
@johnwatkins0 yep, I think you're right that #21 is covered here, thanks! I'll let @adamsilverstein determine if anything else is needed on this PR, as he'll run the release as 1.0.0 is deemed ready. |
|
Resolves #21. |
|
Also, resolves #32 |
added 2 commits
October 16, 2019 08:24
adamsilverstein
previously approved these changes
Oct 16, 2019
added 2 commits
October 16, 2019 08:26
# Conflicts: # autotweet.php # readme.txt
adamsilverstein
previously approved these changes
Oct 16, 2019
|
Also fixes #18 |
adamsilverstein
approved these changes
Oct 16, 2019
This was referenced Oct 16, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for tracking changes for the 1.0.0 release. Target release date: TBD
Fixes: #21
Release steps
develop, cut a release branch namedrelease/1.0.0for your changes.autotweet.phpif it does not already reflect the version being released.CHANGELOG.mdandreadme.txt.potfile by runningnpm run makepot..github/action-release/rsync-filter.txt.Leaving steps below for a follow up PR to do the actual release:
develop, then do the same fordevelopintomaster.mastercontains the stable development version.masterbranch to GitHub, e.g.git push origin master.stablebranch and test for functionality locally.1.0.0on thestablebranch in GitHub. It should now appear under releases and in the WordPress admin as an update as well.Due date (optional)field) and link to GitHub release (in theDescriptionfield), then close1.0.0milestone1.0.0do not make it into the release, update their milestone to1.1.0orFuture Release