Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 9to5mac version features #1

Merged
merged 5 commits into from
Jan 28, 2019
Merged

Conversation

adamsilverstein
Copy link

Complete changes from 9to5 in this PR, these need some reviewing & testing before merging into the plugin.

@adamsilverstein
Copy link
Author

  • XSS prevention - switch from .innerHTML to text
  • alignment cleanup
  • strict comparisons for in_array
  • end comment sentences in periods
  • pass and use post id in opted_into_auto_tweet, fixes an issue for scheduled posts
  • array alignment
  • check that all _GET parameters exist before using
  • ensure tweet meta updates works as expected, deleting values first before setting
  • escape all output
  • sanitize all input
  • avoid retweeting when updating published posts
  • double check post is valid before tweeting
  • pass and use post id in status_update
  • improve inline docs
  • rename Publish_Tweet helper class file
  • Fix include paths, strict equality checks

Copy link

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamsilverstein looks awesome. Just wondering if there should be some kind of admin notice if there is an issue authenticating Twitter?

@@ -1,7 +1,10 @@
<?php
/**
* Responsible for the registration and display of the metabox.
*
* @package tenupautotweet;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing here but I think the package should match the namespace that this class in. In this case TenUp\Auto_Tweet\Core perhaps

@adamsilverstein adamsilverstein changed the title [WIP] Merge 9to5mac version features Merge 9to5mac version features Jan 28, 2019
@adamsilverstein adamsilverstein merged commit 8f84877 into master Jan 28, 2019
@jeffpaul jeffpaul added this to the 1.0.0 milestone Mar 8, 2020
@jeffpaul jeffpaul deleted the feature/9to5version branch June 30, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants