Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build step in update-wpdororg-assets.yml #165

Merged
merged 1 commit into from
May 20, 2022
Merged

Add build step in update-wpdororg-assets.yml #165

merged 1 commit into from
May 20, 2022

Conversation

iamdharmesh
Copy link
Member

Description of the Change

This PR add build step to "Plugin asset/readme update" GH action to fix failure on action.

Closes #164

Alternate Designs

Possible Drawbacks

Verification Process

Plugin asset/readme update GH action should run successfully.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - Plugin asset/readme update GH action failure

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this May 20, 2022
@iamdharmesh iamdharmesh requested a review from jeffpaul May 20, 2022 13:45
@iamdharmesh iamdharmesh added this to the 1.2.0 milestone May 20, 2022
jeffpaul
jeffpaul approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@jeffpaul jeffpaul merged commit af4b3b3 into trunk May 20, 2022
@jeffpaul jeffpaul deleted the fix/164 branch May 20, 2022 13:47
@jeffpaul jeffpaul linked an issue May 20, 2022 that may be closed by this pull request
"Plugin asset/readme update" GH action is failing to deploy readme.txt #164
Closed
@iamdharmesh iamdharmesh modified the milestones: 1.2.0, 1.1.2 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
None yet
Projects
Open Source Practice
Archived in project
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

"Plugin asset/readme update" GH action is failing to deploy readme.txt
2 participants
@iamdharmesh @jeffpaul