Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin name and branding #293

Merged
merged 19 commits into from
Dec 19, 2023
Merged

Update plugin name and branding #293

merged 19 commits into from
Dec 19, 2023

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Nov 13, 2023

Description of the Change

This PR works to rename from "Autoshare for Twitter" to "Autopost for X (formerly Autoshare for Twitter)" (where we can drop the part in parens at a later date) as well as updates references of "Twitter" to "X/Twitter" (where we can drop the Twitter part at a later date). Also pending will be an update of the banner/icon images.

There's still all the PHP/JS files to go through here on the renaming, hoping @iamdharmesh can help finish that off.

How to test the Change

Changelog Entry

Changed - Renamed plugin from "Autoshare for Twitter" to "Autopost for X (formerly Autoshare for Twitter)".

Credits

Props Morgan Hartnett, @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.2.0 milestone Nov 13, 2023
@jeffpaul jeffpaul self-assigned this Nov 13, 2023
@iamdharmesh iamdharmesh mentioned this pull request Nov 23, 2023
17 tasks
@jeffpaul
Copy link
Member Author

@iamdharmesh I'm working to get the banner/icon updates ready, so if you can help update the remaining files here for the renaming that will help unblock this change for release before year end... thanks!

@iamdharmesh
Copy link
Member

@jeffpaul I have updated Twitter references in Codebase. Now, the below things are pending to make this ready for merge, I will update it once I get the updated banner and icons.

  1. WP.org assets
  2. Icons in list table and sidebar panel
  3. Screenshots

Also, Just wanted to double-confirm that, is it fine to keep using "Tweet" wording here Or we should update it with "Post"?

image image

Thanks

@jeffpaul
Copy link
Member Author

Also, Just wanted to double-confirm that, is it fine to keep using "Tweet" wording here Or we should update it with "Post"?

Ugh, yeah, I suppose best to update to Post though maybe let's do...
Autopost to X/Twitter enabled
Post to X/Twitter when published
Use featured image in Post to X/Twitter
Autopost to X/Twitter
Posted to X/Twitter on...
Post to X/Twitter now
Post to X/Twitter again

@jeffpaul
Copy link
Member Author

jeffpaul commented Dec 4, 2023

@iamdharmesh FYI that the updated banner/icon images are included in this PR

@iamdharmesh
Copy link
Member

@jeffpaul This is now ready for your review. Please let me know if you want to see this running, I will help with setting up the plugin from this branch on the instawp instance.

@jeffpaul
Copy link
Member Author

@iamdharmesh yes, a test instance would be helpful to preview/test to ensure we've captured all the renaming locations

@jeffpaul
Copy link
Member Author

Some items from testing:

  1. Would be good to expand the column for the labels on the Settings page so they can appear on a single row (none are too long)
Screenshot 2023-12-14 at 11 59 08 AM
  1. Update Autoshare to Autopost
Screenshot 2023-12-14 at 12 00 31 PM
  1. Update auto-tweet to auto-post and Tweet to Post.
Screenshot 2023-12-14 at 12 01 21 PM
  1. Update text in this scenario from "This post was not posted to X/Twitter." to "This post has not been posted to X/Twitter."
Screenshot 2023-12-14 at 12 04 38 PM
  1. Update button text in this scenario to "Post to X/Twitter"
Screenshot 2023-12-14 at 12 05 52 PM
  1. Update hover-text from Tweeted status to Autopost status (header row & footer row)
Screenshot 2023-12-14 at 12 07 54 PM
  1. There's no hover text in the sample above where the page hasn't been posted to x, would probably be good to add something like "Has not been Posted to X/Twitter"

  2. Screen Options display update from "Tweeted status" to "Posted to X/Twitter status"

Screenshot 2023-12-14 at 10 27 01 PM
  1. Worth scanning remaining codebase in the branch for additional references of "tweet", "Twitter", and "autoshare" to see if there are other places we've missed that are user-facing

@iamdharmesh
Copy link
Member

@jeffpaul Thanks for the feedback, I have addressed it and updated the latest branch to Instawp instance.

@jeffpaul
Copy link
Member Author

Looks good @iamdharmesh, thanks!

@iamdharmesh iamdharmesh marked this pull request as ready for review December 19, 2023 16:18
@iamdharmesh iamdharmesh self-requested a review as a code owner December 19, 2023 16:18
@github-actions github-actions bot added the needs:code-review This requires code review. label Dec 19, 2023
@iamdharmesh iamdharmesh merged commit 6ea58f0 into develop Dec 19, 2023
17 checks passed
@iamdharmesh iamdharmesh deleted the update/naming branch December 19, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants