-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename tenup-auto-tweet -> autotweet #42
Conversation
@adamsilverstein Should we also update the namespace from There are also a few hooks and functions using the underscored |
@johnwatkins0 Both good suggestions, I'll work on changing those. |
@johnwatkins0 this is ready for a re-review if you have a chance. |
@adamsilverstein Looks like there are still a few instances of |
@johnwatkins0 Good catch, I'll update this again. |
# Conflicts: # includes/class-publish-tweet.php
Got those renamed @johnwatkins0 as well as changing "tenup-autotweet" to "autotweet" in a few other places in 12b4145 Doing some testing locally to make sure nothing is broken, ready for a re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @adamsilverstein! We should do another check once both this and #44 are merged just in case #44 is introducing any new auto-tweet
s or auto_tweet
s
Going to merge so we can fix any conflicts in other PRs and go forward from this base. |
Description of the Change
Fixes #22.
10up-auto-tweet
->autotweet
.taut
->autotweet
.Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Checklist:
Applicable Issues
Changelog Entry