Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename tenup-auto-tweet -> autotweet #42

Merged
merged 9 commits into from
Sep 27, 2019
Merged

Conversation

adamsilverstein
Copy link

Description of the Change

Fixes #22.

  • Rename 10up-auto-tweet -> autotweet.
  • Rename namespace taut -> autotweet.

Alternate Designs

Benefits

  • More consistent naming.
  • Works with wp.org upgrader.

Possible Drawbacks

  • Meta key has changed so existing users won't see correct information for past tweets, tweets could be double published

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul added this to the 1.0.0 milestone Sep 16, 2019
@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Sep 16, 2019
@johnwatkins0
Copy link
Member

@adamsilverstein Should we also update the namespace from Tenup\Auto_Tweet\ to Tenup\Autotweet?

There are also a few hooks and functions using the underscored auto_tweet or tenup_auto_tweet. Should we update these as well?

@adamsilverstein
Copy link
Author

@johnwatkins0 Both good suggestions, I'll work on changing those.

@adamsilverstein
Copy link
Author

@johnwatkins0 this is ready for a re-review if you have a chance.

@johnwatkins0
Copy link
Member

johnwatkins0 commented Sep 27, 2019

@adamsilverstein Looks like there are still a few instances of auto-tweet (no 10up-) and Auto-tweet hanging around. Do you think we should update these?

Screen Shot 2019-09-26 at 8 11 26 PM

@adamsilverstein
Copy link
Author

@johnwatkins0 Good catch, I'll update this again.

@adamsilverstein
Copy link
Author

Got those renamed @johnwatkins0 as well as changing "tenup-autotweet" to "autotweet" in a few other places in 12b4145 Doing some testing locally to make sure nothing is broken, ready for a re-review.

Copy link
Member

@johnwatkins0 johnwatkins0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @adamsilverstein! We should do another check once both this and #44 are merged just in case #44 is introducing any new auto-tweets or auto_tweets

@adamsilverstein
Copy link
Author

Going to merge so we can fix any conflicts in other PRs and go forward from this base.

@adamsilverstein adamsilverstein merged commit b72fd0b into develop Sep 27, 2019
@adamsilverstein adamsilverstein deleted the fix/rename-autotweet branch September 27, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename to autotweet
3 participants