Adds JSON extension as a Composer requirement

[moebrowne]

Description of the Change

Adds JSON PHP extension as a Composer requirement as the extension is being used

Alternate Designs

N/A

Benefits

Ensures that supporting modules are installed before the code is run

Possible Drawbacks

N/A

Verification Process

No code changes were made

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

N/A

[adamsilverstein]

Hi @moebrowne - thanks for the PR! Overall this looks good especially if it resolves an issue.

Can you clarify where you see "the extension is being used" and what code causes problems before this change?

What issue you were seeing that led you to opening this PR?

[adamsilverstein]

Note tests are failing as well, not sure why.

[moebrowne]

Hi, The JSON extension must be installed else the calls we make to the json_* functions will error. You can see examples of where they're used here:

• https://github.com/10up/distributor/blob/develop/includes/classes/Authentications/WordPressDotcomOauth2Authentication.php#L401
• https://github.com/10up/distributor/blob/develop/includes/classes/ExternalConnections/WordPressExternalConnection.php#L813

I'm not sure why the tests are failing as I haven't changed any code?

[adamsilverstein]

Ah, thanks for clarifying @moebrowne, that makes sense!

I wonder why we aren't using wp_json_encode in these instances which should work in all contexts and not require the JSON extension. In general I'd prefer we stick to this built in WordPress function rather than add an additional dependency.

Can you see any reason not to go that direction instead?

[dinhtungdu]

I agree that we should use wp_json_encode too.

We have this issue because some PHP installs don't include PHP JSON extension. Prior to 5.3, WordPress uses some workarounds/polyfills to ensure the functionality json_* functions. From WordPress 5.3, PHP Native JSON Extension is required to run WP, see: https://make.wordpress.org/core/2019/10/15/php-native-json-extension-now-required/

@jeffpaul @dkotter I suggest we close this PR and create a new one to replace json_* functions by the wp_ versions.

[dinhtungdu]

@jeffpaul, after digging into the codebase of Distributor, I want to hold my suggestion above, json_encode and json_decode are using in our classes, tests, and the plugin-update-checker library that we ship with Distributor. So I think the most reliable approach now is @moebrowne solution.

[jeffpaul]

@dkotter any disagreements with @dinhtungdu's latest approach noted above?

[dkotter]

@jeffpaul @dinhtungdu Nope, this sounds good to me.