Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style and tweak hookdoc output #482

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Conversation

helen
Copy link
Contributor

@helen helen commented Nov 7, 2019

Description of the Change

Leverages JSdoc config to do the following:

  • Uses a layout.tmpl override
  • Uses a specific README file for home content
  • Includes a 10up-specific stylesheet (actual styling in progress)

Alternate Designs

See #481, #480

Benefits

Can explain what this site is for, point to other resources, and make it look nice and 10uppy.

Possible Drawbacks

More maintenance?

Verification Process

npm run build:docs locally

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

See #387. Also noticed in working on this that the docblocks still need some more work, in particular naming params and adding @returns to filters so they are separated from actions.

* Uses a layout.tmpl override
* Uses a specific README file for home content
* Includes a 10up-specific stylesheet (in progress)
@jeffpaul jeffpaul added this to the 2.0.0 milestone Nov 7, 2019
@jeffpaul jeffpaul added needs:documentation This requires documentation. type:enhancement New feature or request. labels Nov 7, 2019
@helen helen changed the title [WIP] Style and tweak hookdoc output Style and tweak hookdoc output Nov 8, 2019
@helen
Copy link
Contributor Author

helen commented Nov 8, 2019

I'm sure I could futz with how it looks all day, but I think it's at least decent looking now. Design team may want to come in and save us someday but not too bad for basic developer docs :)

Home

Screen Shot 2019-11-07 at 8 06 51 PM

Hook

Screen Shot 2019-11-07 at 8 07 06 PM

@helen helen marked this pull request as ready for review November 8, 2019 02:10
Copy link

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@adamsilverstein adamsilverstein merged commit 9b8fdda into develop Nov 8, 2019
@jeffpaul jeffpaul mentioned this pull request Jan 21, 2020
@jeffpaul jeffpaul deleted the try/hookdoc-tmpl-override branch June 30, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation. type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants