Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added urldecode() to fix searching multiple words during a multisite pull #533

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

petenelson
Copy link
Contributor

Description of the Change

Fixes a bug when searching for posts using multiple words during a multisite pull.

Verification Process

Verified searching by single and multiple words in a multisite pull works.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#522

Changelog Entry

  • Fixed a bug when searching for posts using multiple words during a multisite pull.

@jeffpaul jeffpaul added this to the 2.0.0 milestone Feb 28, 2020
@jeffpaul jeffpaul added the type:bug Something isn't working. label Feb 28, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petenelson This worked great in my test! I think we should add a test case for this to ensure this works with future releases. A WPAcceptance test case fits perfectly here. If you don't have time, I can work on adding tests.

@dinhtungdu
Copy link
Contributor

Added WPAcceptance test, see the Travis result here: https://travis-ci.org/github/dinhtungdu/distributor/builds/662967718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants