Fix: Check for value of remote post id to verify push result #574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We're checking for the existence of
post_id
key, not the value of it. There is a case where post_id equals0
, and we still assume that the push is successful.See #488 (comment)
For some reasons, I can't update #492, this PR is made to replace it.
Verification Process
See #488 (comment).
Checklist:
Applicable Issues
Fixes #488 and closes #492.
Changelog Entry