Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check for value of remote post id to verify push result #574

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Mar 31, 2020

Description of the Change

We're checking for the existence of post_id key, not the value of it. There is a case where post_id equals 0, and we still assume that the push is successful.
See #488 (comment)

For some reasons, I can't update #492, this PR is made to replace it.

Verification Process

See #488 (comment).

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #488 and closes #492.

Changelog Entry

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 31, 2020
@dinhtungdu dinhtungdu marked this pull request as ready for review March 31, 2020 01:37
@dinhtungdu
Copy link
Contributor Author

Note that we still need #570 to be merged for passing the tests.

@jeffpaul jeffpaul added this to the 1.6.0 milestone Mar 31, 2020
@dkotter dkotter self-requested a review April 10, 2020 14:32
@dkotter dkotter merged commit 4b72113 into develop Apr 10, 2020
@dkotter dkotter deleted the fix/488 branch April 10, 2020 16:06
@dkotter dkotter mentioned this pull request Apr 20, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not handled response Bad Request from spoke site.
3 participants