Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix images, remove gutenberg beta support, add caveat to README.md #598

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

jeffpaul
Copy link
Member

Description of the Change

As noted in #597, the admin bar and Distributor push menu is not visible in Gutenberg's fullscreen mode. This PR adds a caveat to README.md that notes this issue and recommends disabling fullscreen mode until a resolution is available. While editing the README.md I noticed some images were misaligned so I adjusted those as well as removed out section on Gutenberg support being in beta (while we may have some bugs in Gutenberg support, Distributor generally distributes Gutenberg content fine).

Alternate Designs

Ship an actual resolution to #597 instead of a caveat.

Benefits

Ensures we highlight a workaround until #597 is resolved.

Possible Drawbacks

None identified though this caveat is a bit buried in the README.md, but it at least gives us something to link to in any related support requests.

Verification Process

Manually verified via the GitHub web UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Relates to #597.

Changelog Entry

## Changed
- Documentation updates

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Jun 12, 2020
@jeffpaul jeffpaul added this to the 1.6.0 milestone Jun 12, 2020
@jeffpaul jeffpaul requested a review from helen June 12, 2020 03:37
@jeffpaul jeffpaul self-assigned this Jun 12, 2020
@helen helen merged commit 539dc0c into develop Jul 1, 2020
@helen helen deleted the update/readme branch July 1, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants