Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop committing built files and update GH Actions references #95

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

helen
Copy link
Contributor

@helen helen commented Jul 8, 2020

Description of the Change

Update some GH Actions version references and run the build process in CI instead of committing built files.

Alternate Designs

n/a

Benefits

No more committed built files! Latest and greatest GH Actions for release/update!

Possible Drawbacks

If we add more stuff to the build process the asset updater might not be able to run successfully unless it is updated to work better with build processes in the meantime.

Verification Process

As usual, wait and see, though these are copied from existing working plugins.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

See #77 for a time where the built version was (understandably) not in the PR and was forgotten about.

Changelog Entry

Guess it needs one in the release branch?

This means no more committed built files.
@helen helen added this to the 1.2.0 milestone Jul 8, 2020
@helen helen requested a review from dinhtungdu July 8, 2020 22:21
@helen helen mentioned this pull request Jul 9, 2020
6 tasks
dinhtungdu
dinhtungdu previously approved these changes Jul 9, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the node version used in the build? I need to use node 10 to install and build assets for simple podcasting.

@dinhtungdu dinhtungdu dismissed their stale review July 9, 2020 10:12

Need to clarify node version first

@helen helen merged commit c1c2836 into develop Jul 10, 2020
@helen helen deleted the update/gh-actions branch July 10, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants