Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mocker function for _n() #163

Merged
merged 7 commits into from
Sep 23, 2022
Merged

Fixed mocker function for _n() #163

merged 7 commits into from
Sep 23, 2022

Conversation

jigneshnakrani088
Copy link
Contributor

Fixes #162

@unfulvio-godaddy unfulvio-godaddy added this to the 0.5.0 milestone Sep 22, 2022
@coveralls
Copy link

coveralls commented Sep 22, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 10.201% when pulling 45dd625 on jigneshnakrani088:fix/_n_mocker into 61e95de on 10up:trunk.

@unfulvio-godaddy unfulvio-godaddy requested a review from a team September 22, 2022 02:22
acastro1-godaddy
acastro1-godaddy approved these changes Sep 23, 2022
View reviewed changes
Copy link

@acastro1-godaddy acastro1-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acastro1-godaddy acastro1-godaddy merged commit 2226576 into 10up:trunk Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acastro1-godaddy acastro1-godaddy acastro1-godaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

_n() function mocker always returns first string (singular)
4 participants
@jigneshnakrani088 @coveralls @acastro1-godaddy @unfulvio-godaddy